search

pop-os / popsicle

Multiple USB File Flasher
MIT License
658 stars 77 forks source link

GitHub Actions: Add Flatpak action #188

Closed cassidyjames closed 1 month ago

cassidyjames commented 2 years ago

This adds a GitHub Actions workflow to test the Flatpak build; this can ensure future changes don't break the Flatpak build. Requires a Flatpak manifest, e.g. from #187

jackpot51 commented 2 years ago

I will wait for #187 to be merged before reviewing this.

jackpot51 commented 2 years ago

Now that #187 is merged, please rebase this so it is one commit on top of master. It should pass CI after that. If you need help, I can do that as well.

cassidyjames commented 2 years ago

I see another issue raised by CI that I've resolved in #189

jacobgkau commented 2 years ago

Rebased on master to include https://github.com/pop-os/popsicle/pull/189 and force CI to rerun.

jacobgkau commented 2 years ago

Looks like this is still failing.

 Starting build of com.system76.Popsicle
========================================================================
Building module popsicle in /__w/popsicle/popsicle/.flatpak-builder/build/popsicle-1
========================================================================
Running: make
make: *** No targets specified and no makefile found.  Stop.
Error: module popsicle: Child process exited with code 2
Error: Build failed: Error: The process '/usr/bin/xvfb-run' failed with exit code 1
cassidyjames commented 1 year ago

@ids1024 where did the generated_sources.json here come from? https://github.com/flathub/com.system76.Popsicle/commit/9c82cfb3924734284ccc85a5fbf38becf597f4c0

It looks like this is failing due to missing that in the repo.

ids1024 commented 1 year ago

https://github.com/flathub/com.system76.Popsicle is updated to the latest release now.

generated-sources.json is generated using https://github.com/flatpak/flatpak-builder-tools/blob/master/cargo/flatpak-cargo-generator.py.