search

pop-os / popsicle

Multiple USB File Flasher
MIT License
633 stars 76 forks source link

AppData: add icon, fix indentation #189

Closed cassidyjames closed 1 year ago

cassidyjames commented 1 year ago

Rather than making this change every build time in the Flatpak manifest, just make it directly in the AppData once and for all. Should fix CI on #188 as a nice side-effect. :wink:

Because there were mixed tabs and spaces in the appdata file, I unified it; as such this is best viewed without whitespace changes, e.g. with https://github.com/pop-os/popsicle/pull/189/files?w=1

ids1024 commented 1 year ago

I guess I used sed just because I was fixing the flatpak package, and it wouldn't be convenient to fix here then tag a release.

So changing that here seems good, and the indentation changes seem reasonable too. :+1:

cassidyjames commented 1 year ago

@n3m0-22 hm, I can't reproduce here. Can you try cleaning your build environment in Builder?

Screenshot from 2022-09-29 17-15-46

n3m0-22 commented 1 year ago

Thanks for the feedback. I've tried that a few times, as well as building on other machines, and keep encountering the same error. I will investigate further tomorrow.