pop-os / repo-curated-free

APT repository configuration for building an apt repository with only free software.
MIT License
11 stars 5 forks source link

Add ProtonVPN to official repository #5

Open calexandru2018 opened 3 years ago

calexandru2018 commented 3 years ago

Hey all 👋

I'm one of the developers of the ProtonVPN client, for Linux.

I was wondering if there is a way for us to be added to the official popOS repositories. We do have our own repos but we'd like to provide a more native approach to our users. All our code is GPLv3. The ProtonVPN clients consist of the following packages:

protonvpn: meta-package that installs both the GUI and CLI protonvon-gui: installs the gui (https://github.com/ProtonVPN/linux-app) protonvpn-cli: installs the CLI (https://github.com/ProtonVPN/linux-cli) python3-protonvpn-nm-lib: the library that interacts with network manager (https://github.com/ProtonVPN/protonvpn-nm-lib) python-proton-client: the library that interacts with our API (https://github.com/ProtonMail/proton-python-client)

Please let me know if you require anymore additional information.

leviport commented 3 years ago

Hi! First of all, thanks for your work on the client apps. I use them frequently and they are quite nice. I think they would be a great addition to the Pop repos.

There is one bug I've found though (looks like the one described here). I'd be a little concerned about our customers encountering that bug and adding to the volume of tickets our support team has to handle.

Do you know when a fix for that bug is expected?

calexandru2018 commented 3 years ago

Hey @leviport , thanks for your reply. Yes it is known, as this issue will occur mainly if one turns off the machine while being connected the VPN. Also I understand your concern and it is perfectly valid. We'll prioritize this in the following weeks, and once it's fixed and pushed to our stable branch, I'll ping here.

I've got a question though, how does this work ? Do you just add our stable repo to the curated repo list ?

leviport commented 3 years ago

Sorry for the slow response. I believe we generally prefer to pull in source packages and add them to our repos rather than add third-party sources, but our engineers can evaluate what makes the most sense when we get closer to adding these packages.

mmstick commented 3 years ago

It is possible to clone a repository, but it's better if we can build it from sources in our CI. Which would entail cloning the git repository, and our CI will build it if it contains a working debian directory that can build with sbuild.

calexandru2018 commented 3 years ago

@leviport and @mmstick thanks for the replies. We already have a fix for the bug above and should be deployed on beta this week. So in 1-2 weeks we should be able to proceed on some more definitive solution on how to add the ProtonVPN client in your repo.

We could go with the best approach for you, it doesn't matter for us. Either git cloning from github (then you would have to subscribe to our releases) or copy and add our repo.

I'm actually maintaining myself AUR packages here, so git cloning would be 100% ok.

calexandru2018 commented 2 years ago

Hey @mmstick and @leviport, so good news. The fixes have been pushed last week to beta. I've recently tested them myself on both PopOS versions (20.04 and 21.04) and both worked well upon reboot/shutdown. I've first installed the stable one (which does not contain the fix) and then upgraded to beta and did the exact test.

  1. Download: https://protonvpn.com/download/protonvpn-beta-release_1.0.1-1_all.deb
  2. purge previous stable package: sudo apt purge protonvpn-stable-release
  3. Install previous package by either double-clicking or using the terminal
  4. Upgrade packages: sudo apt upgrade
  5. Connect to vpn and restart with both terminal and power button -> restart

Edit: It just has been pushed to stable

mmstick commented 2 years ago

We'll look into having it in our repository soon