pop-os / shell

Pop!_OS Shell
GNU General Public License v3.0
4.83k stars 261 forks source link

Window exception that is not based on the title #1644

Open bashfulrobot opened 1 year ago

bashfulrobot commented 1 year ago

This is not a bug but rather a question.

Currently, in the config.json for window exceptions, it seems to use the app name for the class, and then use the window title.

IE (generated using the GUI)

{
  "float": [
    {
      "class": "pop-shell-example",
      "title": "pop-shell-example"
    },
    {
      "class": "zoom",
      "disabled": true
    },
    {
      "class": "Brave-browser",
      "title": "test alert"
    }
  ],
  "skiptaskbarhidden": [],
  "log_on_focus": false
}

In my use case, I use a browser extension with my calendar, and the windows are the notifications (additional features from the in-system notifications). However, the window title reflects the name of the event name - which will obviously be different for each one.

Any suggestions here?

Thank you.

mmstick commented 1 year ago

Exceptions may be defined by wm_class and/or wm_title. Regular expressions are supported in the config file. Some of the default rules are using them.

Most web browsers usually don't have a wm_class defined on their dialogs, so we auto-exclude windows without that property set.

I do recall that we added rule for Firefox so that its developer tools window would float by default.

bashfulrobot commented 1 year ago

Thanks for the info! I think I am skunked as the window title is literally the event title, and no common pattern to match.

I guess we can close this off unless you want to track it for some purpose.

mmstick commented 1 year ago

Perhaps it's worth patching the extension to set a more descriptive title or class.