search

pop-os / shell

Pop!_OS Shell
GNU General Public License v3.0
4.77k stars 262 forks source link

Select Floating Windows Exceptions not working with gnome 45 #1662

Closed khalangy closed 8 months ago

khalangy commented 8 months ago

(1) Issue/Bug Description: Select floating windows exceptions is not working since gnome 45, nothing apend after click on a windows to add to exceptions.

(2) Steps to reproduce (if you know): Go to PopShell Menu in top bar > Floating Windows Exceptions > Select > Click on a windows

(3) Expected behavior:

Exception added after clicking on a windows

(4) Distribution (run cat /etc/os-release): Arch linux 

NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

(5) Gnome Shell version:

yay -Q gnome-shell                        
gnome-shell 1:45.0+r17+gebf2f8036-1

**(6) Pop Shell version 

yay -Q gnome-shell-extension-pop-shell-git
gnome-shell-extension-pop-shell-git r940.5b7afc6-1

(7) Where was Pop Shell installed from: AUR

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc): Laptop : eDP connected primary 1920x1080+0+0 (normal left inverted right x axis y axis) 309mm x 174mm

(9) Other Installed/Enabled Extensions:

user-theme@gnome-shell-extensions.gcampax.github.com
appindicatorsupport@rgcjonas.gmail.com
blur-my-shell@aunetx
WallpaperSwitcher@Rishu
supergfxctl-gex@asus-linux.org
dash-to-dock@micxgx.gmail.com
clipboard-history@alexsaveau.dev
arch-update@RaphaelRochet
Hide_Activities@shay.shayel.org
pop-shell@system76.com
apps-menu@gnome-shell-extensions.gcampax.github.com
launch-new-instance@gnome-shell-extensions.gcampax.github.com
light-style@gnome-shell-extensions.gcampax.github.com
native-window-placement@gnome-shell-extensions.gcampax.github.com
auto-move-windows@gnome-shell-extensions.gcampax.github.com
caffeine@patapon.info
notification-position@drugo.dev

Thanks for helping

khalangy commented 8 months ago

There is the log error in the journalctl , hope that can help to resolve the issue

JS ERROR: Exception in callback for signal: hiding: TypeError: ModalDialog is not a constructor
AddExceptionDialog@file:///home/user/.local/share/gnome-shell/extensions/pop-shell@system76.com/dialog_add_exception.js:7:23
exception_add@file:///home/user/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:318:17
on_focused@file:///home/user/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:607:18
signals_attach/<@file:///home/user/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:1529:22
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
_changeShownState@resource:///org/gnome/shell/ui/overview.js:314:14
_animateNotVisible@resource:///org/gnome/shell/ui/overview.js:635:14
hide@resource:///org/gnome/shell/ui/overview.js:619:14
activateWindow@resource:///org/gnome/shell/ui/main.js:837:14
_onCloneSelected@resource:///org/gnome/shell/ui/workspace.js:1408:18
_activate@resource:///org/gnome/shell/ui/windowPreview.js:557:14
_init/<@resource:///org/gnome/shell/ui/windowPreview.js:119:51
@resource:///org/gnome/shell/ui/init.js:21:20
Neo-29 commented 8 months ago

Confirmed too