pop-os / shell

Pop!_OS Shell
GNU General Public License v3.0
4.85k stars 262 forks source link

Gnome 47: TypeError when attempting to enable pop shell #1732

Open CodeAndGin opened 1 week ago

CodeAndGin commented 1 week ago

(1) Issue/Bug Description: Just upgraded to Gnome 47, Pop Shell encounters "TypeError: window.is_client_decorated is not a function" when I try to enable the extension from the extensions menu.

(2) Steps to reproduce (if you know):

(3) Expected behavior:

(4) Distribution (run cat /etc/os-release): Arch Linux

(5) Gnome Shell version: Gnome 47

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

Commit ced5442

(7) Where was Pop Shell installed from: Git

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc): 1 x 2K

(9) Other Installed/Enabled Extensions: Arch Linux Updates Indicator Auto Move Windows Blur My Shell Caffeine Dash to Dock Launch New Instance Native Window Placement Removable Drive Menu Rounded Window Corners Reborn (slightly modified by me for an extra colour option) Screenshot Window Sizer Transparent Window Moving User Themes

I also tried disabling all of these and logging out and in, before attempting to start pop shell, same issue.

(10) Other Notes:

CodeAndGin commented 1 week ago

Update; a power cycle seems to have resolved the issue, unsure why.

HideyoshiNakazone commented 1 week ago

The problem is on the Meta.Window interface, in Meta 15 the Window interface has switched from the is_client_decorated method to the decorated.

mgamigo commented 1 week ago

I am having the same issue, but it is not getting resolved by power cycle. When I reboot the extension appears as activated, but is not working. If I disable it (in order to restart the extension), I get the error back:

"TypeError: window.is_client_decorated is not a function"

McCio commented 1 week ago

The problem is on the Meta.Window interface, in Meta 15 the Window interface has switched from the is_client_decorated method to the decorated.

I executed sed -i 's/is_client_decorated/decorated/g' src/*.ts before make and now it works wonderfully again! As I understand that change is not backward compatible for Gnome 45 and 46, so I won't submit a PR, as I guess it will require more testing.

mgamigo commented 1 week ago

Thanks for the hint @McCio. I am currently installing it via the AUR and I would like to continue that way. I hope that the fix it soon.

CodeAndGin commented 1 week ago

further update; power cycling stopped the error from occurring, but tiling doesn't work, and if I rebuild with either the original or with @McCio's modification, both seem to throw the TypeError (but "window.decoration is not a function" with the mod). This is not the sort of thing I'm particularly good at troubleshooting unfortunately =/

lutzseverino commented 4 days ago

Same as @mgamigo here. I use the AUR and the extension doesn't work right now. Prefer to just uninstall until this problem is resolved.