pop-os / shell

Pop!_OS Shell
GNU General Public License v3.0
4.86k stars 263 forks source link

Maximized application gets de-maximized when another application in another workspace is closed #400

Open REIS0 opened 4 years ago

REIS0 commented 4 years ago

Distribution (run cat /etc/os-release): NAME="Pop!_OS" VERSION="20.04 LTS" ID=pop ID_LIKE="ubuntu debian" PRETTY_NAME="Pop!_OS 20.04 LTS" VERSION_ID="20.04" HOME_URL="https://system76.com/pop" SUPPORT_URL="http://support.system76.com" BUG_REPORT_URL="https://github.com/pop-os/pop/issues" PRIVACY_POLICY_URL="https://system76.com/privacy" VERSION_CODENAME=focal UBUNTU_CODENAME=focal LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy pop-shell or provide the latest commit if building locally): pop-shell: Installed: 0.1.0\~1589925465\~20.04\~ff5f374 Candidate: 0.1.0\~1589925465\~20.04\~ff5f374 Version table: *** 0.1.0\~1589925465\~20.04\~ff5f374 1001 1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main amd64 Packages 1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main i386 Packages 100 /var/lib/dpkg/status

Issue/Bug Description: When another window in another workspace is closed, the window in the first workspace is no longer in maximized mode. ezgif-4-f3a8ee91435a

Steps to reproduce (if you know):

  1. Maximize an application in a workspace
  2. Open another application in the workspace below
  3. Close this application
  4. When back to the first workspace is no longer maximized

Expected behavior: The first application staying in maximized mode.

Other Notes: I'm in a dual monitor setup.

REIS0 commented 4 years ago

this also causes ardour to transpose the screen and become unusable when the option maximize editor space is activated in the view menu

image

jmmaranan commented 4 years ago

@REIS0 - can you please update to the latest apt release or pull from the latest release branch master_focal. And if you still see this issue?

If still not working, question for you: Does it un-maximize say you started the first window as 50x50% (or any arbitrary) size, then maximize, open the second window on 2nd workspace, close 2nd window. Does the 1st window go back to 50x50%? E.g. image

REIS0 commented 4 years ago

@jmmaranan can confirm is still happening with last apt release (gonna update later if the master branch has this issue).

About the second question, I think I got it right the explanation but sorry if I misunderstood something.

What I set is like this: tilling activated and gaps set to 5, I'm in workspace 1 and open firefox or whatever app and use the maximize shortcut (super+M) to enter the max mode, then I change to the free workspace I have, in this case workspace 2, and open another window of whatever app, then I close this window that was in workspace 2 and go back to workspace 1, the app that was in max mode is no longer in max mode, is back to the "normal" mode with gaps appearing in it. Just to know that there's no more than one window in the workspaces, both workspace 1 and 2.

EDIT: short answer to the second question: yes, is something like this.

jmmaranan commented 4 years ago

@REIS0 - sorry but I cannot reproduce this. Do you mind to let know what other extensions you have installed?

Also, if you have Gnome Tweaks, scrolling to the Workspaces section, can you let me know if Workspaces span displays. And if Workspaces are dynamic?

Also you mentioned Ardour being impacted, while I don't use it, do you know if you have the flatpak or deb installed?

REIS0 commented 4 years ago

@jmmaranan here the list image when I'm testing pop shell tidalwm is disabled since it does the same thing

Workspaces are dynamic and in primary display only

Ardour from the default repos

I'm gonna test again with extensions disabled, maybe can be related

EDIT: fix typing

EDIT 2: Tested with extensions disabled, same problem, below is showing the problem in a better way, changed the wallpaper and added the second monitor

ezgif-3-bfbf33c23f81

REIS0 commented 4 years ago

Just another thing, I'm actually thinking in opening a feature request for smart gaps feature similar to the one in i3-gaps, since I basically just use the max mode to manually simulate this behaviour.