Rebase on upstream version 7.3.0

pop-os / shop

Pop!_Shop

GNU General Public License v3.0

89 stars 19 forks source link

Rebase on upstream version 7.3.0 #416

Closed jacobgkau closed 9 months ago

jacobgkau commented 10 months ago

This is a true rebase, starting from the upstream 7.3.0 tag and adding actively-desired changes back. This is upstream's latest release, made on June 27th.

This only needs to be tested on jammy since focal and bionic have their own master_ branches.

Obsoletes https://github.com/pop-os/shop/pull/401. (UX discussions from that PR as well as https://github.com/pop-os/repoman/pull/113 have been taken into account here.)

Tested & working:

[X] Installing, opening, and removing a .deb app.
[X] Installing, opening, and removing a Flatpak app.
[X] Installing mixed .deb/Flatpak updates.
[X] The menu items and keyboard shortcuts for opening the Automatic Update settings and Repoman.

mmstick commented 10 months ago

Does this fix the crashes that we were seeing before?

mmstick commented 10 months ago

This does appear to have fixed the crashes. Categories are slow to load, but that's probably because the category views aren't paginated.

jacobgkau commented 10 months ago

Yeah, it seemed to be more stable than the previous rebase PR during my limited testing so far.

jacobgkau commented 10 months ago

I'm just fighting with Vala trying to get the buttons in the InstallFailDialog to work properly at this point. (Upstream changed how the response is connected when they added a new Flatpak repair button to theirs.)

jacobgkau commented 10 months ago

Finally got our custom InstallFailDialog options working.

~~Now working on making updates work.~~ Looks like they actually work, but currently throw an error anyway.

jacobgkau commented 10 months ago

Fixed that error message, updates are working normally now.

The Pop!_Shop/AppCenter's still not perfect, but I think all of the regressions from the currently-released version have been addressed now. This still needs full regression testing from another QA member. Engineering review might want to take a look at the patch commits (I made the most minimal changes possible in an effort to help stability.)

leviport commented 9 months ago

I want to take a little more time looking at this, but so far it's looking very good. Stability seems to be greatly improved, and I haven't found anything that doesn't seem to be working right.