search

pop-os / system76-acpi-dkms

System76 ACPI Driver (DKMS)
GNU General Public License v2.0
16 stars 11 forks source link

Guard System76 EC specific functionality #14

Closed crawfxrd closed 2 years ago

crawfxrd commented 3 years ago

Certain functionality or its implementation in System76 EC firmware may be different to the proprietary ODM EC firmware. Introduce a new bool, has_open_ec, to guard our specific logic. Detect the use of this by looking for a custom ACPI method name used in System76 firmware.

Resolves: #15

jacobgkau commented 2 years ago

This does not seem to get the keyboard backlight working on galp4 (with Open Firmware/proprietary EC.)

jacobgkau commented 2 years ago

On 39e8894, I still have no keyboard backlight on galp4. I do have backlight on darp6 proprietary EC and Open EC.

It's come to my attention that our lab galp4's keyboard backlight connector is physically damaged, but I don't think that should affect the current testing. I see the OSD when pressing Fn-F4 on galp4 Open EC, while I don't see the OSD when pressing Fn-F4 on galp4 proprietary EC; and the Keyboard Brightness setting in Settings -> Power is not changing when pressing the key on galp4 proprietary EC.

crawfxrd commented 2 years ago

Does the module get unloaded on galp4? If you try to unload/load it does it generate any messages in dmesg?

jacobgkau commented 2 years ago

Sorry, Levi was working on our unit earlier to try and patch the backlight port up.

Good news, I actually do have keyboard backlight control on galp4 now with 39e8894. It's still not showing the OSD on proprietary EC, which is why I couldn't tell it was working when the backlight connector was being finicky.

I do see that the keyboard brightness slider in G-C-C isn't working now, either. Is that expected and/or related to system76-acpi-dkms at all? (darp6 on proprietary EC does have the OSD pop up when I use the hotkeys, which only work after this fix.)