pop-os / system76-acpi-dkms

System76 ACPI Driver (DKMS)
GNU General Public License v2.0
16 stars 11 forks source link

chore: Add dh-dkms as build dependency for Ubuntu 23.04 (Lunar) #22

Closed jacobgkau closed 1 year ago

jacobgkau commented 1 year ago

Checking if this resolves the build issue on Launchpad.

Before the change:

Command: dpkg-buildpackage -us -uc -mLaunchpad Build Daemon <buildd@lcy02-amd64-074.buildd> -b -rfakeroot
dpkg-buildpackage: info: source package system76-acpi-dkms
dpkg-buildpackage: info: source version 1.0.2~1678132042~23.04~ed01124~dev
dpkg-buildpackage: info: source distribution lunar
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean --with dkms
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
dh: error: unable to load addon dkms: Can't locate Debian/Debhelper/Sequence/dkms.pm in @INC (you may need to install the Debian::Debhelper::Sequence::dkms module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.36 /usr/share/perl/5.36 /usr/local/lib/site_perl) at (eval 10) line 1.
BEGIN failed--compilation aborted at (eval 10) line 1.

make: *** [debian/rules:6: clean] Error 25
dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2023-04-26T23:20:00Z
jacobgkau commented 1 year ago

There was a typo in the package name, which caused the source build to fail.

Looks like the source build is now working, but the binary build still failed:

13:47:18 system76-acpi-dkms: 6d240c8da3bac58e15ec71f80f5777e03fb6f108 (fix-build_lunar): lunar (23.04): amd64: binary building
13:47:18 system76-acpi-dkms: 6d240c8da3bac58e15ec71f80f5777e03fb6f108 (fix-build_lunar): lunar (23.04): binary-amd64 github status pending
13:47:22 E: apt-get update failed
13:47:22 system76-acpi-dkms: 6d240c8da3bac58e15ec71f80f5777e03fb6f108 (fix-build_lunar): lunar (23.04): amd64: binary failed: exit status: 3
13:47:22 system76-acpi-dkms: 6d240c8da3bac58e15ec71f80f5777e03fb6f108 (fix-build_lunar): lunar (23.04): binary-amd64 github status failure
jacobgkau commented 1 year ago

Still getting the apt-update failed error, not sure where that needs to be fixed.

jacobgkau commented 1 year ago

I have confirmed on a local Ubuntu 23.04 machine that dh-dkms is required (so this PR is required), but on the local machine, the build works after installing that package, so whatever's failing now is specific to the build server.

jacobgkau commented 1 year ago

The build seems to be working now after force-pushing again, not sure what changed.