pop-os / system76-driver

System76 Driver for Pop!_OS
Other
112 stars 29 forks source link

Move settings to xprofile and don't overwrite existing settings. #182

Closed jacobgkau closed 3 years ago

jacobgkau commented 3 years ago

Fixes #179.

While placing this command in /etc/profile.d did not impact the ability to use multiple displays, it did cause the display configuration to be lost if /etc/profile is re-run after login, and caused error messages when logging in remotely. This PR makes the following changes:

I'm testing thoroughly and will un-mark as draft when this is ready for full review.

jacobgkau commented 3 years ago

Tested the following scenarios on Pop 20.10 and Ubuntu 20.04:

(For the record, I also double-checked that ForceFullCompositionPipeline is still needed before making this PR, and it is still needed on this machine.)

jacobgkau commented 3 years ago

Confirmed the xprofile script still works as intended with one or multiple displays, and all of the test cases from my previous comment still work, with the latest changes on 0642ef8.