Closed jacobgkau closed 3 years ago
Tested the following scenarios on Pop 20.10 and Ubuntu 20.04:
Installing/updating/reconfiguring system76-driver
:
s76-nvidia-fullcomp.sh
exists and xprofile
does not exist (current up-to-date machines), s76-nvidia-fullcomp.sh
is removed and xprofile
is created with the correct contents.s76-nvidia-fullcomp.sh
does not exist and xprofile
exists with the required contents, no action is taken.s76-nvidia-fullcomp.sh
exists and xprofile
exists with the required contents, s76-nvidia-fullcomp.sh
is removed but xprofile
is not modified.xprofile
exists but does not contain the required contents, the contents are added (but prior contents is preserved.)s76-nvidia-fullcomp.sh
nor /etc/xprofile
exist (e.g. a fresh Ubuntu install), /etc/xprofile
is added with the correct contents.After the action has been run:
ForceFullCompositionPipeline
is enabled successfully on boot/login (seen in nvidia-settings
and by the lack of stuttering.)sudo -i
does not flicker the screen or reset display settings.nvidia-settings
.nvidia-settings
.nvidia-settings
on the SSH client.(For the record, I also double-checked that ForceFullCompositionPipeline
is still needed before making this PR, and it is still needed on this machine.)
Confirmed the xprofile script still works as intended with one or multiple displays, and all of the test cases from my previous comment still work, with the latest changes on 0642ef8
.
Fixes #179.
While placing this command in
/etc/profile.d
did not impact the ability to use multiple displays, it did cause the display configuration to be lost if/etc/profile
is re-run after login, and caused error messages when logging in remotely. This PR makes the following changes:/etc/profile.d
./etc/xprofile
, which is only run at graphical login by GDM and other display managers./etc/xprofile.d
does not exist by default, nor does/etc/xprofile
. Using/etc/xprofile.d
would still require creating/etc/xprofile
first, so it's simpler not to use it.CurrentMetaMode
and will appendForceFullCompositionPipeline
onto the existingCurrentMetaMode
so as not to overwrite existing display settings. Only ifCurrentMetaMode
doesn't exist is the defaultnvidia-auto-select
option used.I'm testing thoroughly and will un-mark as draft when this is ready for full review.