pop-os / system76-driver

System76 Driver for Pop!_OS
Other
112 stars 29 forks source link

Fix meer6 audio #200

Closed jacobgkau closed 3 years ago

jacobgkau commented 3 years ago

The snd_hda_intel.power_save=0 option doesn't actually get audio working (accessing the systemd-boot menu to add the option manually is what got audio working while testing that option), so this PR removes that action from the meer6.

This PR also adds a new action to run xrandr --output DP-1 --set audio on on every graphical login using /etc/xprofile.

The meer6 refers to the physical HDMI 1 port as DP-1, and the physical HDMI 2 port as HDMI-1. The HDMI 2 port appears to have working audio without any tweaking needed, while the HDMI 1 port needs the above command to have working audio on boot. (Other actions that trigger xrandr, such as replugging the display or switching the display input, also get audio working, but the above command should make it happen automatically.)

I will be testing this thoroughly once it's done building, marking this PR as a draft until testing is complete.

jacobgkau commented 3 years ago

From a fresh install, after adding this branch, booting with the following configurations (shutting down in between):

It does seem like the ports are physically labeled backwards. The labels look like they could be for the Thunderbolt ports instead of the HDMI ports, but I'm not sure why the Thunderbolt ports would be numbered at all.

I'm also not sure exactly which component was causing the sound issue, but in any case, this workaround gets audio working normally, at least in Xorg. (In addition to Pop 20.10, I also tested on Ubuntu 20.04, and while Wayland isn't explicitly disabled in Ubuntu, 20.04 does still default to Xorg, so the workaround works.)

jacobgkau commented 3 years ago

Converting back to draft because I noticed the /etc/xprofile being added doesn't end with a newline (so viewing it with cat messes up the terminal prompt), going to fix that real quick.

jacobgkau commented 3 years ago

I also thought to try audio and display via USB-C using the two Thunderbolt ports. The rightmost port (labeled 2) has Dummy Audio without this fix but works with this fix, while the leftmost port (labeled 1) works with or without the fix.