pop-os / system76-driver

System76 Driver for Pop!_OS
Other
112 stars 29 forks source link

Added quirk for thelio-massive-b1 and Nvidia GPUS #206

Closed bflanagin closed 3 years ago

bflanagin commented 3 years ago

Adds a quirk to fix issue with massive-b1 and Nvidia GPUs and fixes https://github.com/system76/testing/issues/281

jacobgkau commented 3 years ago

@bflanagin You'll need to run bump-version.py and then add a message in debian/changelog (I always forget to do that.)

jackpot51 commented 3 years ago

@bflanagin I'm going to squash this into fewer commits, and fix the debian/changelog so it is ready for release.

bflanagin commented 3 years ago

@jackpot51 I screwed up my local branch somehow and that last commit is broken. Is there a command to fix it or do I need to recommit once its sane.

jackpot51 commented 3 years ago

Was https://github.com/pop-os/system76-driver/commit/165ed5378d4cdba180425727841e29bdf5cff276 not working?

bflanagin commented 3 years ago

165ed53 worked as intended, however, @jacobgkau made a really good point about future maintenance and suggested we query the number of Nvidia cards detected instead of using 'nvidia-detector'. This way we wont need to update this quirk or the post install script in the future. It uses nvidia-smi which is installed with the nvidia driver and will return 0 if anything other than an nvidia card is present.

However, the main issue is that I screwed up commit is https://github.com/pop-os/system76-driver/pull/206/commits/56c11e805ff7e693e57239be522c2a6ebdb3961b. The one directly before it https://github.com/pop-os/system76-driver/pull/206/commits/a8356d6f85edf57a19cc0d7b74dbfec7698fee1a is good. I know how I screwed up, but not how to fix it without making yet another commit.

jacobgkau commented 3 years ago

@bflanagin https://stackoverflow.com/questions/22682870/git-undo-pushed-commits

jacobgkau commented 3 years ago

The latest solution does not affect Massive with an AMD card installed; the quirk is not applied (which is correct behavior.)

bflanagin commented 3 years ago

Working as expected on the massive that was experiencing the issue.