pop-os / system76-driver

System76 Driver for Pop!_OS
Other
111 stars 28 forks source link

Error fixing internal mic gain with PipeWire #207

Closed phtown closed 3 years ago

phtown commented 3 years ago

Distribution (run cat /etc/os-release): Fedora 34 (Workstation Edition)

Related Application and/or Package Version (run apt policy $PACKAGE NAME): pipewire 0.3.30-2.fc34 system76-driver 20.04.35-5

Issue/Bug Description: Running system76-driver crashes on systems without PulseAudio installed.

Steps to reproduce (if you know): sudo system76-driver-cli produces the following output:

INFO    product_version: 'galp3-b'
Fedora release 34 (Thirty Four)
Fedora release 34 (Thirty Four)
INFO    internal_mic_gain: Fix Internal Mic Gain
INFO    Running 'internal_mic_gain'
INFO    * Fix Internal Mic Gain
ERROR   Error running actions:
Traceback (most recent call last):
  File "/usr/bin/system76-driver-cli", line 72, in <module>
    for msg in action_runner.run_iter():
  File "/usr/lib/python3.9/site-packages/system76driver/actions.py", line 253, in run_iter
    action.perform()
  File "/usr/lib/python3.9/site-packages/system76driver/actions.py", line 294, in perform
    self.atomic_write(self.content, self.mode)
  File "/usr/lib/python3.9/site-packages/system76driver/actions.py", line 215, in atomic_write
    fp = open(self.tmp, 'x')
FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/pulseaudio/alsa-mixer/paths/analog-input-internal-mic.conf.DZFJFXLO2BLWCOP3DRHQ4DHJ'

Expected behavior: system76-driver should either be able to work with PipeWire or at least skip this step on failure and move on instead of crashing.

Other Notes: