search

pop-os / system76-driver

System76 Driver for Pop!_OS
Other
112 stars 29 forks source link

Revert 'Enable ForceFullCompositionPipeline on serw12' #218

Open yochananmarqos opened 3 years ago

yochananmarqos commented 3 years ago

Commit 1c5b57d can be reverted. I can no longer reproduce the issue on Pop!_OS 20.04 / 21.10 nor Manjaro. It must have been fixed with an NVIDIA driver release since then.

yochananmarqos commented 2 years ago

@jackpot51 It's been a year and I see you gave the :+1:

FYI, I'm the system76-driver AUR package maintainer and have been disabling that for quite some time.

jackpot51 commented 2 years ago

I would need confirmation from @pop-os/quality-assurance as to if this is fixed.

jacobgkau commented 1 year ago

@yochananmarqos I am still able to recreate an issue on serw12 with lag in LibreOffice Writer when typing with ForceFullCompositionPipeline disabled (testing on Pop!_OS 22.04.) There is occasionally a very small stutter even with the option, but after removing it, the display consistently falls behind within a few words, with noticeably worse performance than having ForceFullCompositonPipeline enabled.

I did notice that if I have only ForceCompositionPipeline enabled (and not ForceFullCompositonPipeline, which forces ForceCompositionPipeline on), then the LibreOffice performance seems to still be okay. So it could be that we only need ForceCompositionPipeline and not ForceFullCompositonPipeline, but removing the option altogether is not currently possible. Can you confirm if you have ForceCompositionPipeline enabled? I'm wondering if you have some other setting/configuration that's preventing you from seeing the issue, or if it's a difference between hardware units.

jacobgkau commented 1 year ago

Actually, my prior testing was still with NVIDIA driver 470.141.03, since we don't do NVIDIA upgrades unless manually initiated by the user. Upgrading to 515.65.01 does resolve the issue in LibreOffice without any of the options enabled.

However, this still presents a problem since we don't know how many serw12 owners have manually upgraded to the 500/515 driver series yet. If there was a way for us to ensure serw12 units got upgraded to 515, then we could consider dropping the option. (Or perhaps we could make the profile.d script check the NVIDIA driver version and only apply the setting if it's an older version.)