Re major r2.2 line in - Githubissues

pop-os / system76-driver

System76 Driver for Pop!_OS

Other

112 stars 29 forks source link

Re major r2.2 line in #225

Closed 13r0ck closed 2 years ago

13r0ck commented 2 years ago

Minor improvement to #224. Fixes mic-in on Major r2.2, and retains line-in fix from #224

leviport commented 2 years ago

The code looks good to me. If we can verify that these tests, I'm ready to approve:

major-r2.1 rev 1.2 (one of the units in assembly)

Test that mic-in, line-in, and line-out are functional between reboots and suspend/resume on:

[x] Pop 21.10
[x] Pop 20.04
[x] Ubuntu 20.04 (add our PPA, install system76-driver)
[x] Ubuntu 18.04 (custom images from assembly)

major-r2.1 rev 1.1 (lab unit)

Test that mic-in, line-in, and line-out are functional between reboots and suspend/resume on:

[x] Pop 21.10
[x] Pop 20.04
[x] Ubuntu 20.04 (add our PPA, install system76-driver)