search

pop-os / system76-driver

System76 Driver for Pop!_OS
Other
111 stars 28 forks source link

Update logs from `system76-driver` to match support panel #238

Closed wagnerck closed 2 years ago

wagnerck commented 2 years ago

This commit updates the logs generated by system76-driver so they match the ones generated by the Support panel after PR https://github.com/pop-os/support-panel/pull/12.

Specifically, it updates the dump_logs function in util.py so the output filenames and commands match the Support panel output.

wagnerck commented 2 years ago

Looks like this is working as expected, but PRs to system76-driver should be done according to the instructions in the readme.

This didn't seem like it was worth a version bump but I'll go ahead and do so.

wagnerck commented 2 years ago

@leviport Running the version bump script results in the following:

Will bump 'focal' version from '20.04.52' to '20.04.53~~alpha'

I said "no" when it asked to confirm because this doesn't look right to me. Is there a script option that I'm missing here?

leviport commented 2 years ago

That's correct, see https://github.com/pop-os/system76-driver/pull/237/files for reference. Running make-release.py afterwards removes the ~~alpha and the Daily WIP line.

wagnerck commented 2 years ago

@leviport @mmstick Done. The script bumped the version and automatically pushed the changes, so the existing reviews will need to be redone. Sorry about that.

mmstick commented 2 years ago

Ready to merge then?

leviport commented 2 years ago

Yep!

wagnerck commented 2 years ago

Thanks, folks.