pop-os / system76-firmware

System76 Firmware Tool and Daemon
GNU General Public License v3.0
74 stars 28 forks source link

schedule: create temp dir within EFI dir #121

Closed orangecms closed 11 months ago

orangecms commented 11 months ago

I saw the following during an upgrade attempt: moving /boot/efigMxXdR to /boot/efi/system76-firmware-update removing /boot/efigMxXdR system76-firmware: failed to schedule: failed to move /boot/efigMxXdR to /boot/efi/system76-firmware-update: Invalid cross-device link (os error 18)

This appears to be related to moving across file systems; /boot/efi is the ESP, whereas /boot/efiXXXXX is on the root fs, which is ext4. To avoid the cross fs move, simply create the temp dir within the EFI dir.

Signed-off-by: Daniel Maslowski info@orangecms.org

orangecms commented 11 months ago

proposal to fix #120 :grimacing:

crawfxrd commented 11 months ago

Fixed with #122.