search

pop-os / system76-firmware

System76 Firmware Tool and Daemon
GNU General Public License v3.0
75 stars 28 forks source link

Make date and description required fields #99

Closed crawfxrd closed 2 years ago

crawfxrd commented 2 years ago

10e1ad5f141d was a stopgap to ensure nothing would break when adding the date field to the JSON changelogs. Now that all releases have a release date, make it required.

Also make description a required field.

Requires: system76/firmware#430

XV-02 commented 2 years ago

When either date or description is removed from the changelog, the firmware panel reports "No changelog available". If either/both is given an empty string (e.g. "date": "",) the changelog is present, but with those fields empty (currently only description is thus revealed)

Is this the desired behaviour?

crawfxrd commented 2 years ago

That's in firmware-manager, correct? I think it's fine since it's not possible to produce that state in system76/firmware anymore. Only systems that have failed to update the cache will have it.

XV-02 commented 2 years ago

Correct, that is in firmware-manager.