search

pop-os / upgrade

Utility for upgrading Pop!_OS and its recovery partition to new releases.
GNU General Public License v3.0
98 stars 30 forks source link

add clippy msrv config #245

Closed danieleades closed 2 years ago

danieleades commented 2 years ago

adding a clippy 'msrv' config prevents clippy from suggesting changes that use syntax not supported by the chosen compiler version.

this isn't strictly necessary since the compiler version is pinned by the rust-toolchain file, which also constrains the version of clippy that is run. What this allows though is running a later clippy version to check warnings from newer clippy lints, but that are still compatible with the chosen version (cargo +nightly clippy)

mmstick commented 2 years ago

We have control over Rust packaging in Pop so this isn't necessary anymore. I'll be keeping Rust to the latest stable version as needed. We currently have 1.56 and I'll likely upgrade it to 1.58 as soon as it releases.