pop-os / upgrade

Utility for upgrading Pop!_OS and its recovery partition to new releases.
GNU General Public License v3.0
95 stars 29 forks source link

minor refactoring and code quality #246

Closed danieleades closed 2 years ago

danieleades commented 2 years ago

what it says on the tin.

for reference, i'm using the following configuration to hunt these down-

cargo +nightly clippy --all-targets --all-features --workspace -- -W clippy::all -W clippy::pedantic -A clippy::must_use_candidate -A clippy::let_underscore_drop -A clippy::missing_errors_doc -A clippy::missing_panics_doc -A clippy::map_unwrap_or -A clippy::module_name_repetitions -A clippy::cast_possible_truncation

I also have clippy's msrv configured as per #245

the 'allowed' lints are simply to reduce some of the noise in the warnings. IMO the allowed lints should either be addressed or explicitly whitelisted in the crate root

there's a lot of overlap with #210 i'm afraid