pop-os / upgrade

Utility for upgrading Pop!_OS and its recovery partition to new releases.
GNU General Public License v3.0
98 stars 30 forks source link

Refactor/declarative clap #249

Closed danieleades closed 2 years ago

danieleades commented 2 years ago

this is a reimplementation of #150 (turned out to be easier to just do it again)

the derive-based declarative clap API is

this refactor also allowed me to eliminate the psuedo-inheritance of the the cli::Client

this refactor also highlighted a couple of bugs in the original cli, which are harder to spot with clap's fluent API-

I've not addressed either of these issues in this PR