search

pop-os / upgrade

Utility for upgrading Pop!_OS and its recovery partition to new releases.
GNU General Public License v3.0
95 stars 29 forks source link

fix: Revert to 86da11d #274

Closed jacobgkau closed 2 years ago

jacobgkau commented 2 years ago

I did this with git revert --no-commit 86da11d..HEAD followed by a commit, and validated with git diff 86da11d giving no output. If someone from engineering could make sure this was done correctly, that would be great.

(I first tried just branching from 86da11d, but GitHub wouldn't let me open a PR because there were no changes to compare, I'm guessing because master already contains that commit-- we'd need to force-push master to do it that way, which would be bad form. Doing it this way will require another repo-release update to whatever the new commit is once this is merged.)

mmstick commented 2 years ago

I wouldn't mind doing a force push to the right commit, and then the system-updater update would contain all the commits that were reverted.

jacobgkau commented 2 years ago

That sounds like a good plan if you'd rather do it that way.