pop-os / xdg-desktop-portal-cosmic

GNU General Public License v3.0
43 stars 37 forks source link

crate-private type AccessDialogArgs in public interface #21

Open soloturn opened 9 months ago

soloturn commented 9 months ago

when building cosmic-epoch-git the following occurs with commit https://github.com/pop-os/xdg-desktop-portal-cosmic/tree/19a34721456dcd1d84483ca59ffdee2575f5115f

   Compiling xdg-desktop-portal-cosmic v0.1.0 (cosmic-epoch-git/src/cosmic-epoch/xdg-desktop-portal-cosmic)
error[E0446]: crate-private type `AccessDialogArgs` in public interface
   --> src/access.rs:243:1
    |
101 |   pub(crate) struct AccessDialogArgs {
    |   ---------------------------------- `AccessDialogArgs` declared as crate-private
...
243 | / pub fn update_args(
244 | |     portal: &mut CosmicPortal,
245 | |     msg: AccessDialogArgs,
246 | | ) -> cosmic::Command<crate::app::Msg> {
    | |_____________________________________^ can't leak crate-private type
ids1024 commented 9 months ago

That should be easy enough to fix. But what Rust version is that with? I haven't seen that error compiling xdg-desktop-portal-cosmic.

soloturn commented 9 months ago

hmm. good point. this is on arch linux, the versions are confusing, it should be something stable or really new. and it is neither of them, but need to check the other box as well ... first one is:

❯ rustc --version
rustc 1.77.0-nightly (3cdd004e5 2023-12-29)
❯ paru -Qo /usr/bin/rustc
/usr/bin/rustc is owned by rustup 1.26.0-5
yochananmarqos commented 9 months ago

@soloturn I just built it fine with rust 1:1.76.0-1. Your rustup toolchain is out of date and you should be using stable, not nightly.