search

pop-os / xdg-desktop-portal-cosmic

GNU General Public License v3.0
43 stars 37 forks source link

Made Cursor Show By Default If Client Doesn't Request The Cursor Mode #99

Open coolGi69 opened 1 month ago

coolGi69 commented 1 month ago

Within most DEs/WMs, the default handling of cursors when using the ScreenCast protocol is that if the client does not request any, it defaults to showing the cursor.\ Currently, Cosmic is not doing that, causing the cursor to not appear on apps which do not implement this part of the spec (such as Chromium) causing the cursor to be missing when screen sharing.

This is a simple one-line PR just to change the defaults so the cursor can be seen :)

ids1024 commented 1 week ago

The spec seems to say the default should be "hidden", as implemented here already?

https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.impl.portal.ScreenCast.html

The default cursor mode is ‘Hidden’.

coolGi69 commented 1 week ago

Even if it is the default on the spec, no user expects it to be.\ No other desktop uses the default, which you can easily test by attempting to screenshare on Discord (an Electron app which doesn't implement it) and seeing if the cursor appears (which it does on other desktops).