search

pop-os / zfs-linux

Pop!_OS fork of https://salsa.debian.org/zfsonlinux-team/zfs.git
Other
6 stars 2 forks source link

Pop!OS seems to be shipping a known extremely buggy OpenZFS patch #8

Closed rincebrain closed 2 years ago

rincebrain commented 2 years ago

Distribution (run cat /etc/os-release): At least 20.04 and 22.04.

Related Application and/or Package Version (run apt policy $PACKAGE NAME): zfs-linux 2.1.4-1pop1~1650059719~22.04~9934f01

Issue/Bug Description: Pop is shipping Ubuntu's patch 4701-enable-ARC-FILL-LOCKED-flag.patch, as far as I can tell from someone reporting the bug from it against upstream OpenZFS again.

This patch is...very, very bad: https://github.com/openzfs/zfs/issues/10971 https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1906476

If you saw any reports of upgrading to Ubuntu 22.04 eating people's data on ZFS, this was the patch why.

I would strongly encourage you to drop it.

Steps to reproduce (if you know):

Install Pop!OS ZFS package Try to use ZFS Suddenly your data is gone.

Expected behavior:

Retaining your data intact.

Other Notes:

Sorry if this is the incorrect repo, I'm not very familiar with Pop!OS, but this seemed important to report.

deepio commented 2 years ago

https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1906476 is the link for the bug, there's just an accidental b at the end.

rincebrain commented 2 years ago

Thanks, sorry, don't know how that got there.

jackpot51 commented 2 years ago

What specific package has the problem? Can you get the output of apt-cache policy [package]

rincebrain commented 2 years ago

I'm not sure what information you're seeking that isn't in the section labeled "please post package version" in my initial reply, sorry.

jackpot51 commented 2 years ago

Can you post the full output of apt-cache policy zfs-linux?

rincebrain commented 2 years ago

No, because I'm not running Pop!OS, I'm just here reporting something that someone tried to report against OpenZFS again and we said "oh no, another distro shipped that broken patch."

kentrosi commented 2 years ago 
zfs-dkms:
--
  | Installed: 2.1.4-1pop1~1650059719~20.04~9934f01
  | Candidate: 2.1.4-1pop1~1650059719~20.04~9934f01
  | Version table:
  | *** 2.1.4-1pop1~1650059719~20.04~9934f01 1001
  | 1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main amd64 Packages
  | 1001 http://ppa.launchpad.net/system76/pop/ubuntu focal/main i386 Packages
  | 100 /var/lib/dpkg/status
  | 0.8.3-1ubuntu12.14 500
  | 500 http://us.archive.ubuntu.com/ubuntu focal-updates/universe amd64 Packages
  | 500 http://us.archive.ubuntu.com/ubuntu focal-updates/universe i386 Packages
  | 0.8.3-1ubuntu12.9 500
  | 500 http://us.archive.ubuntu.com/ubuntu focal-security/universe amd64 Packages
  | 500 http://us.archive.ubuntu.com/ubuntu focal-security/universe i386 Packages
  | 0.8.3-1ubuntu12 500
  | 500 http://us.archive.ubuntu.com/ubuntu focal/universe amd64 Packages
  | 500 http://us.archive.ubuntu.com/ubuntu focal/universe i386 Packages
mmstick commented 2 years ago

I will remove the patch. The patch is still in the latest version of https://salsa.debian.org/zfsonlinux-team/zfs.git so it might be good for Debian/Ubuntu to know to remove it.

rincebrain commented 2 years ago

The patch is there, but it's not actually applied in the series file - Debian themselves never shipped it, they just kept it there because they keep the ubuntu/ patch folder, AFAIK.

deepio commented 2 years ago

When will this patch be available in Pop? After updating/upgrading I don't seem to have it yet