This PR removes the inclusion of the Metrics class and instead uses dependency management via Gradle to shade bStats into the artifact. It also updates bStats to 2.2.1.
Github had a stroke displaying the diff, but all I did was reduce nesting by a level due to the removal of the if (metrics.isEnabled()) { } block.
minimize() was added because it removes a lot of useless classes from bStats for charts and data types we don't use, and is generally a good idea to use unless a specific shaded dependency requires all classes to be present at runtime. Caution should be used in the future in ensuring such shaded dependencies are excluded from minimize where needed.
I have tested to make sure data was still being reported correctly, and everything works fine:
This PR removes the inclusion of the Metrics class and instead uses dependency management via Gradle to shade bStats into the artifact. It also updates bStats to 2.2.1.
Github had a stroke displaying the diff, but all I did was reduce nesting by a level due to the removal of the
if (metrics.isEnabled()) { }block.minimize()was added because it removes a lot of useless classes from bStats for charts and data types we don't use, and is generally a good idea to use unless a specific shaded dependency requires all classes to be present at runtime. Caution should be used in the future in ensuring such shaded dependencies are excluded from minimize where needed.I have tested to make sure data was still being reported correctly, and everything works fine: