Build instructions include manually copied external dependencies

popcorn-official / popcorn-desktop

Popcorn Time is a multi-platform, free software BitTorrent client that includes an integrated media player ( Windows / Mac / Linux ) A Butter-Project Fork

https://popcorn-time.site

Other

8.97k stars 612 forks source link

Build instructions include manually copied external dependencies #144

Closed kumavis closed 8 years ago

kumavis commented 8 years ago

The readme explains that the following files must be pulled from the website:

popcorntime.sh/package.json
popcorntime.sh/torrent_collection.js
popcorntime.sh/ysubs.js

Why are they not part of the source control? Seems to unnecessarily complicate the build setup.

kumavis commented 8 years ago

If its determined unnecessary I'm happy to update the documentation.

VitorVRS commented 8 years ago

Hi, some months ago, DMCA notified GitHub that this repo should remove this files because their are infringing some copyright. So, team pct had to remove these files and make and workaround. If you see git history you will see the commit https://github.com/popcorn-official/popcorn-desktop/commit/d5125bc4d643b3c401e481cdd0d77c511e79aa11

If you want, i can paste the email GitHub sent to me to remove these files.

kumavis commented 8 years ago

woah crazy - those files in particular? or just needed to neuter the system in some way. id love to see the email, its quite interesting.

Breaking1 commented 8 years ago

@kumavis here you can see it what it was all about:

https://github.com/github/dmca/blob/master/2016-03-16-MPAA.md

kumavis commented 8 years ago

package.json, destroyer of worlds