search

popcorn-official / popcorn-desktop

Popcorn Time is a multi-platform, free software BitTorrent client that includes an integrated media player ( Windows / Mac / Linux ) A Butter-Project Fork
https://popcorn-time.site
Other
9.37k stars 620 forks source link

Science Fiction filtering doesn't work #160

Closed kaypoush closed 7 years ago

kaypoush commented 8 years ago

Hi,

Science Fiction filtering doesn't work and returns "No movies found...". Only the "Movies" and "Series" sections are concerned.

Info :

I tried a fresh reinstall but it still doesn't work.

Thanks.

VitorVRS commented 8 years ago

It seems that PCT API its not returning content for "Sci-Fi" content. I could not get PCT API url to make some tests, maybe @team-pct can check if there are something wrong with this genre on API.

beppe9000 commented 8 years ago

I confirm this on Windows 10 Pro. Here is a screenshot showing the problem: popcorn-time_2016-06-12_15-56-05

finwefeanor commented 8 years ago

not only scifi category is empty, also most movies-tv series had been misplaced in some wrong categories. It's probably related to this issue i don't know.

this is one of the examples: adsasdasdadsasd

finwefeanor commented 8 years ago

even the lord of the rings doesn't have a "fantasy" title on it, some scifi products have fantasy title.

I don't want to start an argue about what movie is fantasy or what is not, just simply pointing out that for some shows , some categories are essential. lotr

beppe9000 commented 8 years ago

How can Star Wars be fantasy and not science fiction? I think something is wrong with IMDB... applicationframehost_2016-06-25_17-19-40

finwefeanor commented 8 years ago

You just need to scroll down beppe screenshot_2016-06-25-18-42-53

Sci fi movies can also include fantasy most of the time(because there are many fantasy elements in star wars also) but they always labelled as sci fi along with fantasy. But fantasy movies can not include sci fi most of time. You can't see game of thrones as sci fi.

beppe9000 commented 8 years ago

The question is: how does popcorn time get the list of movies for a genre? Can we have an example url to investigate? Maybe popcorn time has an hardcoded list of genres somewhere and the api doesn't recognize the science fiction one? ie. popcorn time has sci-fi and the api has scifi

finwefeanor commented 8 years ago

Honestly I don't know I am not a programmer (just beginner), I came here to report this problem and seen it has already been reported, just wanted to add something. I don't know if api is gathering data from a hard-coded list but it seems to me that this is somehow related to developers who didn't want to spend many time to correcting genres. Because not only sci fi genre is the issue, most of the movies and shows have been generalized. Almost all of them includes "action adventure". Yes they are very common genres in movie industry but come on almost every movie or show in popcorn time includes this.

finwefeanor commented 8 years ago

And I don't know if popcorn time has an editable interface (it says open source) but if it can be editable like imdb, users can fix this problems by manually(correcting genres of movies and shows). Developers might not be needed if it can be fixed this easily.

beppe9000 commented 8 years ago

I investigated further.

This is an example v2 API call to get metadata about a sci-fi movie: https://yts.ag/api/v2/movie_details.json?movie_id=5768

An an excerpt of its result, showing its genres.

[...]
      "genres": ["Action", "Drama", "Sci-Fi", "Thriller"]
[...]

Now let's compare with what is defined in PCT: the configuration uses "Sco-Fi" too, so I'm baffled, here.

ChrisAlderson commented 8 years ago

Hello,

I was reading the comments on this issue and I'm here to clear a few things up.

First of all what content gets provided by the kind of content. For now the movies are still coming from the API of yts.ag and the TV series/shows are coming from the popcorn-api. Since PT does not have control over the YTS API they cannot fix issues with their API, but PT can fix issues with the show API as it is open source and publicly available. The popcorn-api does also provide movies, but these are not used for PT yet as you'll need a new butter-provider. A new version of PT is in the make to support this butter provider, so in the future both movie and show content will be given out by the popcorn-api.

Secondly I'm here to clear things up about the metadata. The popcorn-api gets its metadata from trakt.tv and not IMDB as they do not have a nice API to get metadata from. Since trakt.tv and IMDB are separate entities their metadata can be different from each other. This is also the reason why ratings and sorting can look different if you are used by the metadata provided by IMDB. Sadly I do not know where the API of YTS is getting its metadata.

Thirdly and lastly the issue with the Sci-Fi content. This should be fixed in the latest version of the API as shown here. This is a quick and dirty solution and this should be fixed by the client-side (desktop and mobile applications), but for now this will have to do. And again since PT does not have any control over the YTS API we cannot fix it on the movie side of PT. If there is other content of a genre not showing like with Sci-Fi you can check the supported genres here.

I hope this helped clear somethings up, but if you have any other questions I'm pleased to answer them.

Yours sincerely,

Chris

twyzeas commented 8 years ago

What I can tell is both 'sci-fi' and 'film-noir' has the same issue. I assume it's the hyphen what causing the problem, but I'm no coder, so can not tell for sure. Can you confirm or disprove?

ChrisAlderson commented 7 years ago

The genre 'film-noir' should work correctyl, only the database does not contain any movies with this genre. A version of the popcorn-api which fixes the issue with the 'Sci-Fi' genre should be in production atm so I'm closing this issue.

beppe9000 commented 7 years ago

It is working now! :D

twyzeas commented 7 years ago

It is working now! :D

Definitely not for me. As far as I can tell there was no update (still version 3.9), and clicking on Sci-Fi gives me still no results.

beppe9000 commented 7 years ago

Try a fresh install: delete the popcorn time folders from appdata (do a backup first, in case you want to restore the watched database) and then install again.

I am using 3.9 on Windows 10 x64. (This version: https://github.com/popcorn-official/popcorn-desktop/tree/43d3386b0555ab18366492bbaf5a91dbac432648)

twyzeas commented 7 years ago

Thanks, a fresh reinstall solved it!