search

popcorn-official / popcorn-desktop

Popcorn Time is a multi-platform, free software BitTorrent client that includes an integrated media player ( Windows / Mac / Linux ) A Butter-Project Fork
https://popcorn-time.site
Other
9.37k stars 620 forks source link

403 on nw:build? #202

Closed OmarShehata closed 7 years ago

OmarShehata commented 8 years ago

I just downloaded the master branch on Windows 8, ran npm install and got all the dependencies. When I run gulp build everything works until it hits an error saying

Received status code 403: https://get.popcorntime.sh/repo/nw/

Here's the full output:

http://puu.sh/pQmHW/bf0825f47b.png

Is anyone else getting this error? It looks like just opening https://get.popcorntime.sh/repo/nw/ in the browser shows a broken nginx page. How long has this been down? Is there anything I can do to work around this?

VitorVRS commented 8 years ago

You should use the main branch (development).

Ekinoks commented 8 years ago

Same error on Ubuntu 16.04 with development branch

OmarShehata commented 8 years ago

Switched to development, same error. Can anyone confirm they can run it?

pellaeon commented 8 years ago

I'm also getting this error on development branch.

deercoder commented 8 years ago

same error on MAC, and also on development branch

pellaeon commented 8 years ago

I figured out a way to extract the required files from the packages, I wrote the note here (also includes some steps to make it start without error, I will file bug reports later.)

OmarShehata commented 8 years ago

Temporary fix: Go into Gruntfile.js and comment out this line:

download_url: 'https://get.popcorntime.sh/repo/nw'

And gulpfile.js and comment out:

downloadUrl: 'https://get.popcorntime.sh/repo/nw/',

VitorVRS commented 8 years ago

You should not comment this line, because on another point in gulpfile it is use to concat to the NW file corresponding to your machine (e.g linux32, linux64, windows...)

OmarShehata commented 8 years ago

@VitorVRS do you know how to fix this so it builds? Is there a mirror out there to https://get.popcorntime.sh/repo/nw/ ? Or another way? @pellaeon 's fix looks promising but I'm not sure if it will work on Windows, since I'm not sure how to extract the binaries like that.

ItachiSan commented 8 years ago

I would suggest, instead of removing the line, of using Butter's NW.JS. The downloadUrl sets the path where there's the needed NW.JS release tarball; removing it falls back on official NW.JS runtime, which does not provide the codecs that the PCT NWJS do. As Butter also uses the same tarball of PopcornTime (I suppose, for sure is closer to PCT one that the official one), I suggest to all the builders to use https://raw.githubusercontent.com/butterproject/nwjs-prebuilt/master/ as download URL. Cheers :smile:

OmarShehata commented 8 years ago

Thanks @ItachiSan ! I'll give that a shot. I assume that's why I was able to build, I could not get any videos to actually play.

Rudloff commented 8 years ago

@ItachiSan The URL you suggested fails with this error:

Received status code 400: https://raw.githubusercontent.com/butterproject/nwjs-prebuilt/master/
ChrisAlderson commented 7 years ago

https://get.popcorntime.sh/repo/nw/ should be accessible, so I'm closing this issue.