popcorn-official / popcorn-desktop

Popcorn Time is a multi-platform, free software BitTorrent client that includes an integrated media player ( Windows / Mac / Linux ) A Butter-Project Fork
https://popcorn-time.site
Other
9.49k stars 628 forks source link

Resumes wrong file selection after restart #2440

Open joeytwiddle opened 2 years ago

joeytwiddle commented 2 years ago

Is your feature request related to a problem? Please describe. After watching an episode of a series, and closing the player, I see the Seedbox has stopped the torrent.

But if I click play ▶️ to start the torrent again, it starts to download new episodes, which I don't want!

I do not have space in RAM or on disk to download an entire series!

Describe the idea you'd like I would like it to keep seeding after I watched the episode (so I don't need to press ▶️)

I would also like it to STOP downloading.

Describe alternatives you've considered Additional context If the goal is to download the next episode, then that makes sense, but it would be good if:

joeytwiddle commented 2 years ago

I'm on commit 03205b426 from last week. I will fetch the latest.

I forgot to say, I'm seeing this only with torrents where the torrent contains multiple episodes. The play button is the one for the entire torrent.

The behaviour I described might be inconsistent. Like sometimes it just decides to download a random episode! But it doesn't always.

So I will look out for an example where we can reproduce it.

joeytwiddle commented 2 years ago

Thanks for your feedback. The overlapping of files and blocks might indeed be part of the issue. But anyway this is not a big problem, so I think it's fine to close for now.

I did find an example, although it's not quite what I described before. I think restarting Popcorn Time might be what triggers the issue. I will note the steps to reproduce, in case we want to come back to this in future:

  1. Ensure you have the settings
    • "Resume seeding after restarting the app?" enabled, and
    • "Clear Cache Folder after closing the app?" disabled
  2. Download S01E01 of The Office (2005) at 1080p resolution
  3. Note that this torrent misbehaves: it is downloading "S01E01 Deleted Scenes". (I think that's just a data bug, not popcorn-desktop's fault).
  4. So, scroll down the seedbox list to start downloading the real "S01E01", and then trash the "S01E01 Deleted Scenes"
  5. Watch some or all of the episode
  6. Then stop Popcorn Time and restart it
  7. Now we can see the seedbox is busy downloading some episodes we never requested!

If I find any more examples, I will note them here too.

By the way, thanks for the recent changes, including the expanded search box! :+1: