popcorn-official / popcorn-desktop

Popcorn Time is a multi-platform, free software BitTorrent client that includes an integrated media player ( Windows / Mac / Linux ) A Butter-Project Fork
https://popcorn-time.site
Other
9.5k stars 630 forks source link

Temporary unresponsive UI on clicking certain movie covers. #3038

Closed theakhandpatel closed 2 months ago

theakhandpatel commented 3 months ago

Operating System Version:

Windows 11 22631.4037

Popcorn Time Version:

0.5.1 https://github.com/popcorn-official/popcorn-desktop/commit/e484724a

Download date:

23 Aug 2024

Download URL:

https://github.com/popcorn-official/popcorn-desktop/releases/tag/v0.5.1

Expected Behaviour:

When I click on a movie cover, it should either show a loader or load the movie details instantly

Actual Behaviour:

on certain movies(I checked with Indian films), the screen goes unresponsive after clicking on the cover, and the hand hover icon is consantly displayed. After a few seconds, the details page is loaded.

Steps to reproduce the behaviour:

  1. Look for Indian films. (Kalki 2898 AD, Raayan, Phir aayi haseen...) .
  2. Click on the cover
  3. The screen goes unresponsive

Screenshot(s) of issue or error(s) logs of developer console (Windows/Linux: F12, MacOS: ⌘ + 0 ... then 'console' tab) (recommended):

6b720e0b-79c5-480f-86ca-c14b8073d2bd (1) (1)

the time taken is probably due to a delay in an API response(this fails and causes a timeout).I found that the following API call is made for these types of movies only(might be some provider-related config)

curl 'http://api.themoviedb.org/3/movie/tt12735488?api_key=***************&language=en&append_to_response=videos,credits' \
  -H 'Accept: application/json, text/javascript, */*; q=0.01' \
  -H 'Referer;' \
  -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36'

I could look only this far https://github.com/popcorn-official/popcorn-desktop/blob/development/src/app/lib/views/item.js:237 it would be better if we added a spinner and allowed the mouse to hover as normal on other covers but disabled the click.