Closed Coleyra closed 10 years ago
@sammuel86 i was the last one to change the web site, @Coleyra if you want i can update the site and make some of the translations
Well, we need to think of long term. We can't change every translation each time we modify the main one.
We should base the work with a mechanism of translation like on the main app. So we need to use a dynamic language like PHP for example.
I have some experience with it, I'm web developer and work with php and other languages, I can do something for this, but would only be in php or several pages and would be better with the base and then several languages in jquery?
Well i'm a PHP web dev too, so we can work together to make something good and persistent. I don't think that translating page with JS is a good idea, we should probably go with something like PHP and gettext.
BTW i'm french so i can easily translate the site in french.
yes, it can be that to
Well, i don't know what's the best way to do it in an open source project :) Do we need some naming standard, or something like that ?
I suggest using PHP + poeditor.com for translation on the frontend we dont have more than 1k strings so we can use the free version.
We can also use http://i18next.com
PHP + poeditor.com is a good thing i think.
But my question was, if we want to translate the title of the page, how do we do ?
Initial code #1 (from Homepage) : <title>Popcorn Time - Watch torrent movies instantly</title>
Method #1 : <title><?php echo _('Popcorn Time - Watch torrent movies instantly'); ?></title>
Method #2 : <title><?php echo _('home-title'); ?></title>
Initial Code #2 (from FAQ) : <article id="update"> <h2>Will there be a new version?</h2> <p>Most definitely. You're going to have to download it manually though. But fear not! If you're on version Beta 2, you'll be notified within the app. Other than that, we'll let you know through Facebook and/or Twitter.</p> </article>
Method #1 : <article id="update"> <h2><?php echo ('Will there be a new version'); ?>?</h2> <p><?php echo "Most definitely. You're going to have to download it manually though. But fear not! If you're on version Beta 2, you'll be notified within the app. Other than that, we'll let you know through Facebook and/or Twitter."; ?></p> </article>
Method #2 : <article id="update"> <h2><?php echo ('faq-update-title'); ?></h2> <p><?php echo ('faq-update-content'); ?></p> </article>
I suggest method #1 we can make it dynamic and new content will be automatically pushed to poeditor with the api.
Something like that: <?php echo _("Watch torrent movies instantly"); ?>
So, if the english sentence is changed, what will happen ?
You got a good point. What you think using method #2 hehe
But I think it'll be easier to manage with method #1 but I think method #2 will be more "clean". As we don't have a lot of translation to import
I'm ok for Method #2 but we need a standard for this :)
Something like : pagename-category-element ?
I'll try to do it tomorrow, with english / french.
pagename-category-element that make sense to me.
can i have your email i'll add you admin of the project on poeditor you can send it to phnz @ freenode
thanks
@Coleyra and @phenomenz i think, the #2 method is better, cleanner and easier, i can do portuguese version
@Coleyra @sharkiller
Guys can you coordinate I think @sharkiller already works on something about it.
Thanks
translation is done in the other branch. langs are in /lang/ only the select menu is missing until we have a good amount of translations.
i will translate to portuguese then, and maybe for other language if its necessary
@SrPatinhas the file going to be uploaded to getlocalization for consistency. and easy maintenance.
@sharkiller i just finnish the translation, if you need something more just tell me ;)
@sharkiller It will be in the same getlocalization project ?
The index.php contain all the method to get the language, but if we want to do it on other pages we need to place this code in a separate file. Are we placing it in a new directory, and what will be the name of the file ?
include/essential.php
inc/getLanguage.php
function/main.php
./header.php
other ?
I can do the translation in romanian if you need it
@PatruSorin yes, how many more languages better, so if they need anything do not need to see in other languages than maternal.
@Coleyra and @sharkiller i still do not quite understand how this works and that :S some of you will be able to explain if you give me please?
And another point, much as, for example I'm Portuguese and I live in Portugal, to have the site translated into Portuguese because the IP from where I am (do not know if and how it works) could for example be in France or in another country Portuguese and wanting the same, this is a point that I say, you can not have so much importance and do not be the most.
sorry if it's not this, just have not figured it well
For now we are just using a parameter in the url to set the language, something like => get-popcorn.com/?lang=pt Maybe in the future we can use IP detection or subdomains for other languages like => pt.get-popcorn.com or get-popcorn.com/pt
@SrPatinhas Yes romanian is my first language but where should I post the translation after it is done?
@PatruSorin go to https://github.com/popcorn-official/popcorn-site/tree/multilang-phptest/lang and make a pull request and translate the text there, i made a pt.php in my fork
Some already done a lot of work to translate the previous site (which was very similar). Go check https://github.com/remil19/popcorn-time.github.io
It's very easy : changes are made in dev/index.php and languages/*.json and the whole site is generated automatically.
english master added to: http://www.getlocalization.com/PopcornTime/ go there for translations
Since popcorn-time is already translated in multiple languages, the website need to be translated too.