popcorn-time-ru / popcorn-ru

Multilang api for popcorn
https://www.reddit.com/r/PopCornTimeApp/
149 stars 61 forks source link

Issue sorting by note #14

Closed MecMada closed 3 years ago

MecMada commented 3 years ago

Operating System Version: Windows10

Popcorn Time Version: 0.4.4

Download date: 16/05/2021

Download url (optional): http://popcorn-ru.tk/build/Popcorn-Time-0.4.4-win64-Setup.exe

Expected Behaviour When sorted by note, the first film should have the best note.

Actual Behaviour When sorted by note, I have "The fast and Furious Tokyo Drift" in choice 1 (6.3/10 IMDb note) and "Blood diamond" in choice 2 (7.5/10 IMDb score)

Steps to reproduce the behaviour Sort by note

Screenshot(s) of issue or error(s) logs of developer console (Windows/Linux: F12, MacOS: ⌘ + 0 ... then 'console' tab) image

ivan1986 commented 3 years ago

Ok, it's incorrect, but same as old api sort

for now get max count votes, but get max rating also incorret

For now i just add this https://www.evanmiller.org/how-not-to-sort-by-average-rating.html https://www.evanmiller.org/bayesian-average-ratings.html https://fulmicoton.com/posts/bayesian_rating/

ivan1986 commented 3 years ago

https://github.com/popcorn-official/popcorn-api/blob/development/src/controllers/ContentController.js#L69

ivan1986 commented 3 years ago

switch to rating and popularity

ivan1986 commented 3 years ago

now cache cleaned and sort by rating but it's garbage, because on top films and series with 10-20 votes for now calculating weight rating, after it will be ready - switch.

ivan1986 commented 3 years ago

all sorting fixed