search

popcron / gizmos

Used for drawing runtime gizmos in builds and editor (Unity3D)
MIT License
549 stars 43 forks source link

Removed empty docs, refactored similar code #6

Closed RunninglVlan closed 5 years ago

RunninglVlan commented 5 years ago

Empty docs like <typeparam name="T"></typeparam> were removed Some of them weren't even related to actual params. Helper methods call main Square or Circle method

Please test that everything works the same, as I edited it in GitHub. ;)

popcron commented 5 years ago

Yeah those were likely either outdated XML comments or not elaborated on. I'll take a look around.

About those method calls, it'd be better if they go straight to the draw instead of the other adapter methods, for consistency. I'm unsure whether the compiler would inline the original method anyways or not, and I prefer to not use a MethodImpl attribute in order to make it look concise.

I'll look further.