popeindustries / lit

Fast server-rendering and client-hydration of lit-html templates and web components
MIT License
33 stars 4 forks source link

Remove directives folder from .gitignore files for lit-html to avoid import error #15

Closed knuthaug closed 2 years ago

knuthaug commented 2 years ago

In version 5.0.4 of @popeindustries/lit-html and @popeindustries/lit-html-server the directives folder, pointed to by the exports map config, was not included in the package, and the import could not be resolved, due to the fact that is is listed in .gitignore since it is generated. This aims to fix that.

Why it seemed to work while testing the previous branch by linking, I still do not know 😢

Fix

ref: https://docs.npmjs.com/cli/v8/using-npm/developers#keeping-files-out-of-your-package

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 9782cbc738a2b116ece1cc395651b04ac34953e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | --------------------------- | ----- | | @popeindustries/lit-html | Patch | | @popeindustries/lit-element | Patch | | @popeindustries/lit | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

knuthaug commented 2 years ago

directives could probably be listed in files in package.json too, as an alternative. You decide what you prefer.