popeindustries / lit

Fast server-rendering and client-hydration of lit-html templates and web components
MIT License
33 stars 4 forks source link

chore: remove soure map urls #39

Closed cristobal closed 4 months ago

cristobal commented 4 months ago

What the title says ☝🏽 , i guess this is a mistake when updating copying lit html sources, since there are no actual source map files packages with the @popeindusctries/lit packages.

What are we trying to avoid

We currently see this error from dvlp, when developing locally

Skjermbilde 2024-06-13 kl  00 01 26

Which this PR will fix.

We have a temp fix

We added this to dvlp for the time being:


  onRequest(req, res) {
   ...

    // Ignore .js.map exceptions from @popeindustries/lit packages
    if (
      req.url?.includes('node_modules/@popeindustries/lit-') &&
      req.url?.endsWith('.js.map')
    ) {
      res.writeHead(200);
      res.end('');
      return true;
    }
  },
``
changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: e3e4d0cae2e207c6cfce107cfdaa1d1d2445baf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages | Name | Type | | ------------------------------- | ----- | | @popeindustries/lit-element | Patch | | @popeindustries/lit-html | Patch | | @popeindustries/lit | Patch | | @popeindustries/lit-html-server | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

popeindustries commented 4 months ago

These are script generated files, so I updated the script

cristobal commented 4 months ago

These are script generated files, so I updated the script

Thanks @popeindustries 🙏🏽