search

popey / ephemeral-snap

2 stars 0 forks source link

Ephemeral Theme wonkiness #2

Open bashfulrobot opened 4 years ago

bashfulrobot commented 4 years ago

image

Hey @popey - If you have a look at the included screenshot, there is some funniness with the theme on the buttons.

Is this because the theme I am running (default budgie theme called Pocillo) is not included in the common themes snap?

popey commented 4 years ago

Thanks for the issue report. I suspect that's exactly the problem. We should probably get that in the common themes, given it's a flavo{u}r default theme. Would you mind filing a bug against the gtk-common-themes ? I think this is where they go https://gitlab.gnome.org/Community/Ubuntu/gtk-common-themes

cassidyjames commented 4 years ago

This was in part because previously I had been requesting a dark variant in GTK, but with the addition of a light/dark switch in 6.2 and because of how WebKitGTK works, I stopped doing that unless a dark style is requested in the menu—but my styling expected other GTK stylesheets to be similar to the Ubuntu or Pop! ones with dark headerbars apparently. It looks like the snap was using Adwaita here (as a fallback) which does not have a dark headerbar.

This issue should be partially resolved by 6.3.2 by me dropping the headerbar styling on non-elementary stylesheets.

bashfulrobot commented 4 years ago

@cassidyjames - Thanks for popping in on this one and clarifying (especially since I know you generally are not providing support outside of Elementary).

:+1:

I appreciate your time.

cassidyjames commented 4 years ago

@bashfulrobot of course! An upcoming 6.3.3 release should also improve non-native theming things slightly, automatically hiding the light/dark toggle if your OS (or the user) is setting a -dark theme, which I know at least Ubuntu 20.04 is adding. So while it's a little but of a bummer losing that slick branded headerbar, it was always a crap-shoot on non-elementary stylesheets—hopefully the less buggy looks overall make up for it.

bashfulrobot commented 4 years ago

That sounds awesome. Looking forward to it. 👍