popgenDK / SATC

Sex assignment through coverage
17 stars 10 forks source link

XZ scaffolds are not written to sexlinked_scaff.list and .list file descriptions are swapped in readme #10

Closed zjnolen closed 2 years ago

zjnolen commented 2 years ago

Hello! Thanks for such an efficient tool, it really works great and is easy to use! Solves an issue I've been trying to sort on my data with other tools almost instantly.

I've noticed that there seems to be a small discrepancy between what the output text suggests:

List of abnormal sex linked scaffolds written to ./leo_sexlinked_scaff.list 
List of XZ scaffolds written to ./leo_XZ_scaff.list 

All scaffolds in ./leo_XZ_scaff.list are also in ./leo_sexlinked_scaff.list

and what I get, as sexlinked_scaff.list contains only the abnormally sex linked and not those in XZ_scaff.list. This seems it can be remedied to match what the text suggests by changing this line to:

write(c(xz,abnormalsexlinked), outlist1)

As well, it seems the definitions for these files are swapped in the readme.

Best, Zach

casia16 commented 2 years ago

Thank you for the input, we have now edited the output text suggestion.

zjnolen commented 2 years ago

Awesome, thanks!