popgenmethods / smcpp

SMC++ infers population history from whole-genome sequence data.
GNU General Public License v3.0
149 stars 32 forks source link

Please add support for `linux-aarch64` to the Conda package #252

Open martin-g opened 8 months ago

martin-g commented 8 months ago

Hello,

At https://anaconda.org/terhorst/smcpp I see that the package supports linux-64 (i.e. x86_64) and osx-64. I'd like to request adding support for linux-aarch64 (Linux ARM64).

With feedstocks usually the steps are:

I see that smcpp maintains its Conda configs here in the repo - https://github.com/popgenmethods/smcpp/commit/c120fcc6c230feb68bf60a97be2657616d4b965e and does not use conda-forge,yml (https://github.com/conda-forge/r-filelock-feedstock/pull/9/files#diff-478786365dd93f740eb520c2faa03d7a0623273663b75472272c8ef94297bbe2R12-R13), so I am not sure what changes are needed exactly.

terhorst commented 8 months ago

Hi, thanks for the request. I no longer distribute Conda packages for SMC++ after running into numerous and seemingly intractable dependency-related issues (cf #164). I am currently looking into what is required to build arm64 Docker images.

martin-g commented 8 months ago

Thanks for the quick answer, @terhorst !

About the Docker ARM64 image - We have added it last year with https://github.com/popgenmethods/smcpp/pull/221 ! You can see a multi-arch image at https://github.com/martin-g/smcpp/pkgs/container/smcpp

To see it in your GHCR.io you will have to make the image public (see https://github.com/popgenmethods/smcpp/pull/221#issuecomment-1291573563)

If you want to publish at Docker Hub then you will have to remove this line https://github.com/popgenmethods/smcpp/blob/8bdecdfa1064c930a620869a4ff53f21609b237c/.github/workflows/docker-push.yml#L26 and update the credentials.

Please let me know if you need help with this!