search

popolo-project / popolo-engine

A reference implementation of Popolo as a Rails engine
MIT License
11 stars 7 forks source link

Upgrade to Rails 4 #13

Closed jpmckinney closed 9 years ago

jpmckinney commented 11 years ago

Read up on:

https://github.com/rails/cache_digests https://github.com/rails/strong_parameters https://github.com/rails/turbolinks https://github.com/rails-api/active_model_serializers

jpmckinney commented 10 years ago

I'll revive this issue if we ever use this engine in a Rails 4 project.

lfalvarez commented 9 years ago

Hey there we were thinking of using popolo engine for a project and our project is using rails 4.1.x. What would be your recomendation for getting it to work ?

lfalvarez commented 9 years ago

I gave it a try and ended up commenting some lines. Unfortunately, due to my lack of rails knowledge I can't understand the implications of this commented lines specially in spec/spec_helper.rb.

Here is the link for the list of commits and the order I followed for commenting things: https://github.com/ciudadanointeligente/popolo-engine/commits/commenting_things_for_rails4 and this is the comparison between that feature branch and master: https://github.com/ciudadanointeligente/popolo-engine/compare/commenting_things_for_rails4

jpmckinney commented 9 years ago

I upgrade to RSpec 3 at the same time. Tests pass in 4.x now! I'll open a branch for 3.x.

lfalvarez commented 9 years ago

:sparkles: thanks! :sparkles: