search

popolo-project / popolo-spec

International legislative data specifications
http://www.popoloproject.com/
99 stars 18 forks source link

Add dates to ContactDetail #46

Closed jpmckinney closed 10 years ago

jpmckinney commented 10 years ago

e.g.

older contact details may help to discover that one of the MP's offices three years ago was located at the same address as a company of a man he claims not to know

Use valid_from and valid_through?

jpmckinney commented 10 years ago

http://popoloproject.com/specs/contact-detail.html

tmtmtmtm commented 10 years ago

I hadn't seen this issue before, or I would have noted that 'through' meaning end, rather than middle, is mainly an American English usage, and sounds quite odd in British English...

jpmckinney commented 10 years ago

Schema.org also has validUntil, which to me sounds like it should have the same meaning. I'll change to that. validThrough was from GoodRelations, which Schema.org adopted.

girogiro commented 10 years ago

JSON schema of ContactDetail and example of its JSON serialization still use valid_through. Is it a bug or intention?

jpmckinney commented 10 years ago

That is a bug! Thanks for reporting. I've corrected those files.