popolo-project / popolo-spec

International legislative data specifications
http://www.popoloproject.com/
99 stars 18 forks source link

Start/end times as well as dates #96

Closed dracos closed 9 years ago

dracos commented 9 years ago

I realise that in almost all cases start/end dates are quite enough. I have two cases in TheyWorkForYou where a membership knowingly changes during a day:

(A Speaker is party neutral and drops their party alignment, this is not simply being given a new office membership.) I have just hard-coded these two, it's not worth doing anything more, but I wondered if it was worth having optional start/end time attributes on memberships also.

jpmckinney commented 9 years ago

We can extend the start_date and end_date regular expressions to include times. What do you think?

breyten commented 9 years ago

Sounds fine with me. In the Netherlands we also have the scenarios like @dracos described above.

jpmckinney commented 9 years ago

@dracos How does adding time to the date properties sound? It just means splitting on the letter "T" in the ISO 8601 format (or actually parsing the date, which you're probably doing anyway).

dracos commented 9 years ago

Sounds good to me (bar confusion over it being called a date, I guess).

akuckartz commented 9 years ago

:+1: