search

popomore / koa-proxy

Proxy middleware for koa
223 stars 102 forks source link

Exposing the cookie jar to the options interface #24

Closed GreenGremlin closed 8 years ago

GreenGremlin commented 8 years ago

fixes #23

popomore commented 8 years ago

Can you add a testcase for this option, with jar or not?

popomore commented 8 years ago

And make travis happy.

GreenGremlin commented 8 years ago

Unit tests added for cookies with and without the cookie jar.

popomore commented 8 years ago

Can you use node4 in travis, that's why ci failed.

GreenGremlin commented 8 years ago

It looks like the failure was caused by the mz package upgrading their version of any-promise. You'll need to register a promise preference with any-promise before requiring koa-static.

https://github.com/kevinbeaty/any-promise

popomore commented 8 years ago

Yes, it's THE Promise adapter, node4 has support it.

GreenGremlin commented 8 years ago

@greim, are you able to take a look at the test failures? I've dug in, but I know nothing about streaming. The tests were passing on Node 5.3, but now seem to be failing on 5.6 as well as 4.3.

popomore commented 8 years ago

Sorry, I'm on vocation all these days. I will check it in weekend.

popomore commented 8 years ago

You can rebase master, it should be fixed by #25

popomore commented 8 years ago

And squash to one commit.

popomore commented 8 years ago

@GreenGremlin Do you have time?

Or I can pick you code.

popomore commented 8 years ago

Land db5278274c52d087e2dee872568c316fb4417353

GreenGremlin commented 8 years ago

Sorry, got busy and lost track. Thanks!