search

popomore / koa-proxy

Proxy middleware for koa
223 stars 102 forks source link

Update to Koa 2 #57

Open edorivai opened 7 years ago

edorivai commented 7 years ago

First attempt to upgrading to Koa 2.

Solves #37

Summary

Problems

I have all test passing, except the encoding test. The problem with this test is that if you want to decode the response body, you'll have to wait for the entire stream to finish. I'm not sure whether decoding the response body should really part of this library. One could simply decode in an upstream middleware if they want, right?

So I have commented out the decoding, and switched the test to pending. Please let me know if you want to keep support for decoding, we can discuss options.

Version

I guess this would be a major version bump, since it will require Koa 2.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling e8a6d36693a61ed43fef116c75531170f4457bbc on edorivai:master into on popomore:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 5bac2f935f465749441f8b84da977e76723443dd on edorivai:master into on popomore:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling fbef5feb1c28f7c14c9e8338f2bac89bf93d906d on edorivai:master into on popomore:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 2a717ca0a6dbbd9c21e031a312ab2a21d0abc61c on edorivai:master into on popomore:master.

moaxaca commented 6 years ago

Please get this merged or publish the fork on NPM. <3

mbarisa commented 6 years ago

Can we get this merged?

chrisveness commented 5 years ago

Since @popomore has apparently abandoned koa-proxy, could you see if npm would transfer the package name to you for you to take the project over?

I think it would be much appreciated!

edorivai commented 5 years ago

@chrisveness I've emailed @popomore, and CC'd npm support. On their disputes page, npm indicates it may take a couple of weeks, so stay tuned!