search

poppinss / indicative

Indicative is a simple yet powerful data validator for Node.js and browsers. It makes it so simple to write async validations on nested set of data.
https://indicative.adonisjs.com/
MIT License
417 stars 52 forks source link

lodash's footprint in bundle size #140

Closed Andreyco closed 6 years ago

Andreyco commented 7 years ago

According to my measures, lodash's size is 526kb - pretty high.

I am sure, not every lodash's API are needed. Is it possible to reduce it's footprint in any way?

Similar to #126

thetutlage commented 7 years ago

Yup, PR is welcome

Andreyco commented 7 years ago

PR in progress...

Andreyco commented 7 years ago

To note, I have progress made on this. If accepted in near future, would love to have it released with other PR (momentjs removal) to keep possible (but not expected) breaking changes in single release.

thetutlage commented 7 years ago

Okay, so I have merged the date-fns PR.

I am thinking of having a separate branch with the frontend bundle logic in using webpack and then start changing the code.

This way we can track, how many bytes we are able to remove. What u think?

Andreyco commented 7 years ago

Thanks for merge, and yes. Please create dedicated branch.

thetutlage commented 6 years ago

Here's the first level build PR https://github.com/poppinss/indicative/pull/153