search

poppinss / indicative

Indicative is a simple yet powerful data validator for Node.js and browsers. It makes it so simple to write async validations on nested set of data.
https://indicative.adonisjs.com/
MIT License
417 stars 52 forks source link

Lock `pope` to `1.0.2`. Version `1.0.3` breaks some tests. #144

Closed Andreyco closed 7 years ago

Andreyco commented 7 years ago

Also, introducing yarn.lock file, which would prevent this situation.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 091772e9eedeec4e0cb799526d404043c973cc56 on Andreyco:develop into a533d9bed4201aef304c3b1956c3301d146760af on poppinss:develop.

RomainLanz commented 7 years ago

Hey !

Please, remove yarn.lock and instead push the official lock file of npm. Note that this issue of pope should be fixed soon.

Andreyco commented 7 years ago

NPM's package-lock.json is in place already.

Since Yarn is very popular, I think it's desired to keep yarn.lock for Yarn users. yarn.lock guarantees everyone will get same install - package developer and end developer as well.

Please, propose further steps.

Andreyco commented 7 years ago

To note, when installed using NPM, correct dependency version is installed thanks to package-lock.json. Essentially, removing yarn.lock let installing broken dependency for Yarn users.

thetutlage commented 7 years ago

The answer is to fix the package that is breaking over adding unwanted layers. Yarn is something I do not use and popularity is not a metric to switch tools

Andreyco commented 7 years ago

The answer is to fix the package that is breaking over adding unwanted layers.

As long as you are an owner of package affecting other package. Would not be that easy if you do not have possibility to fix an issue, of wait ages to get merged.

Yarn is something I do not use and popularity is not a metric to switch tools

I agree popularity is not a metric - quality is. And that's why I care about Yarn users as well as NPM users.

Therefore I strongly believe providing lock file for Yarn users is not unwanted layer, comparing to providing such solution for NPM users.

Notes: only NPM 5 users get benefit of lock file - plus early versions of NPM 5 had problems with lock file. Yarn, on the other hand, understands lock files from day one of it's existence.