Closed pierre-rouanet closed 8 years ago
I disabled the primitive for V-REP in 7ab0fc97ecf287be6e83a0a99353b01ddac565af.
We have to move this primitive directly in pypot and package this sound file in pypot (or poppy-creature ?). Opinions on that @pierre-rouanet ?
I don't think it should go to pypot. The temperature monitoring should be creature based. For instance, we know the torso weakness point is the abs, etc.
For the sound, I think the good strategies is not to rely on sound exclusively. For the moment, on the Ergo we do not have an official way to play sound. So we should at least have another approach. Furthermore, I must say I don't like libraries that print stuff without asking, so playing sound when you just suppose to make motor turn doesn't seem to me like a good idea.
Using the Torso in v-rep may raised an error as the temperature monitoring primitive may now raise an alert (see https://github.com/poppy-project/pypot/commit/f4f727815336b6a58a79583080578c5166f031c0). Yet, the "safety sound" is not packaged with the torso softwares.
I would guess the better solution is to either disable the monitor primitive in v-rep or to simply log when there is a virtual motor "burning" instead of trying to play the sound.