search

popsUlfr / SDH-PauseGames

Decky Loader Plugin for Steam Deck to Pause and Resume games
GNU General Public License v3.0
76 stars 8 forks source link

Use Global DFL #18

Open wynn1212 opened 2 months ago

wynn1212 commented 2 months ago

This pull request primarily addresses the following:

alex-f-k commented 1 month ago

Can confirm, lib bump fixes at least both #16 and #21

decky lib changed staticClasses reference and this line https://github.com/popsUlfr/SDH-PauseGames/blob/78ab7f9c8f259ad322209823948a74e5afb0e328/src/index.tsx#L210 compiled with the old lib produced npe:

-title: window.SP_REACT.createElement("div", { className: deckyFrontendLib.staticClasses.Title }, "Pause Games"),
+title: window.SP_REACT.createElement("div", { className: staticClasses.Title }, "Pause Games"),

@popsUlfr when you have time, could you merge it and publish the new version to the deckbrew? Appreciate your plugin, btw, thanks!

wynn1212 commented 1 month ago

Forget to mention, this patch does work on SteamOS 3.5.19, therefore issue #21 is resolvable

popsUlfr commented 1 month ago

@wynn1212 @alex-f-k Thank you so much for your efforts and sorry for my lack of reactivity.

The issue is that I'm way too out of the loop when it comes to decky and the plugins (I haven't been using decky on my deck), and I just can't invest effort into myself for the foreseeable future unfortunately.

The best course of action would be to submit your own fork of the plugin to the plugin database. You have my approval to take over and submit your own plugin to replace this one (not sure if this means much since right now you know way more about decky than I do to be able to rectify the situation, I mean that's why I would like to delegate).

Mothamoz commented 1 month ago

Hoping to see a fork soon :)

wynn1212 commented 1 month ago

Hi @popsUlfr, Thank you for your affirmation.

But unfortunately, I won't be able to take over this plugin as I'm not familiar with all the codes within it. Additionally, I have other important projects to do.

When I initially encountered this issue, I just happened to found a solution in other plugins, copied it over to this one, and submitted the pull requests. Therefore, I don't believe I'll have the time to contribute further improvements or add additional features to this project.

However, I can suggest that you add some collaborators you trust to this project, perhaps some of the past contributors. If you need the tester to test the new release, I'm also available to assist, as my SteamOS is on the preview channel.

In the meantime, I'll remain available for testing and offer any assistance and fixes to the best of my ability. Thank you for considering my input, and I wish you the best in finding a suitable path forward for the project.

aqlstar commented 1 month ago

Guys, I miss this plugin so much. please update soon. Thank you all

Mothamoz commented 1 month ago

@popsUlfr can you perhaps authorize someone like @wynn1212 to merge PRs for this project so it can continue to be used by many?

popsUlfr commented 1 month ago

But unfortunately, I won't be able to take over this plugin as I'm not familiar with all the codes within it. Additionally, I have other important projects to do.

No need to take over, just this one time you might try to submit the update to the plugin database by pointing to your fork if you can spare the effort. Or even someone else could do just the submitting part and point to your temporary fork.

@popsUlfr can you perhaps authorize someone like @wynn1212 to merge PRs for this project so it can continue to be used by many?

Just merging the PR is not enough, one would need to submit a PR to the plugin database to get it "upstream". I would really prefer to be able to vet any changes to my repo myself first. Otherwise the quickest/easiest way right now is to just point to the temp fork in an update PR to the plugin database.

jackson-xp commented 1 month ago

"Guys, these days without this plugin were really tough, the long loading times in games were torture! Hahahaha!" "Could any energetic mate please help submit it to the Decky Loader database?" ：）

wynn1212 commented 1 month ago

But unfortunately, I won't be able to take over this plugin as I'm not familiar with all the codes within it. Additionally, I have other important projects to do.

No need to take over, just this one time you might try to submit the update to the plugin database by pointing to your fork if you can spare the effort. Or even someone else could do just the submitting part and point to your temporary fork.

@popsUlfr can you perhaps authorize someone like @wynn1212 to merge PRs for this project so it can continue to be used by many?

Just merging the PR is not enough, one would need to submit a PR to the plugin database to get it "upstream". I would really prefer to be able to vet any changes to my repo myself first. Otherwise the quickest/easiest way right now is to just point to the temp fork in an update PR to the plugin database.

Hi @popsUlfr and everyone,

I've submitted a pull request to https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/622. Let's hope they accept it and we can move forward.

EDIT: the pull request has been approved and is now available on Testing Store Channel.

aqlstar commented 1 month ago

it worked! thank you very much!

wynn1212 commented 1 month ago

Hello @popsUlfr,

Since the updated plugin has been approved and merged into the Decky plugin database and is now available in the main store channel, I suggest merging this pull request into your repository to maintain consistency and support future development.

Once again, big thanks to @popsUlfr for approving me to submit the updated plugin to the Decky plugin database.