popsim-consortium / demes-spec

Demes demographic model specification
https://popsim-consortium.github.io/demes-spec-docs/
MIT License
4 stars 4 forks source link

validation section of spec #145

Closed grahamgower closed 2 years ago

grahamgower commented 2 years ago

I'm not quite sure what we should put in here, because (1) a lot of the validation happens during resolution as described in the HDM resolution section, and (2) the remaining details are contained in the MDM section (inter-property requirements) and schema (value ranges for each property).

So maybe we just need some text that ties this all together?

jeromekelleher commented 2 years ago

I think you're right. I guess we just mention this and talk about any additional validation that must be done, beyond what has been discussed already?

grahamgower commented 2 years ago

Yeah, it probably needs a careful read through of the spec to identify any such loose ends.

jeromekelleher commented 2 years ago

Having a look through the reference implementation would probably flag the major stuff that could be filled in as a first pass.

jeromekelleher commented 2 years ago

Basically it's just validating the parts of the model that requires knowledge of the rest of the model, isn't it? We do this separately because we want to know that things have been resolved first so there's no missing data.